From 0a33ebc0fec2624f04dbcbe008ee632c3e7b88d7 Mon Sep 17 00:00:00 2001 From: Lai Jiang Date: Fri, 3 Sep 2021 16:56:57 -0400 Subject: [PATCH] Reformat a file (#1305) * Reformat a file Constants should be SNAKE_CASE named and static fields usually go before instance fields. --- ...ertificateNotificationEmailActionTest.java | 32 ++++++++++--------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/core/src/test/java/google/registry/batch/SendExpiringCertificateNotificationEmailActionTest.java b/core/src/test/java/google/registry/batch/SendExpiringCertificateNotificationEmailActionTest.java index 40ab4c242..8be15db8b 100644 --- a/core/src/test/java/google/registry/batch/SendExpiringCertificateNotificationEmailActionTest.java +++ b/core/src/test/java/google/registry/batch/SendExpiringCertificateNotificationEmailActionTest.java @@ -55,18 +55,7 @@ import org.junit.jupiter.api.extension.RegisterExtension; @DualDatabaseTest class SendExpiringCertificateNotificationEmailActionTest { - @RegisterExtension - public final AppEngineExtension appEngine = - AppEngineExtension.builder().withDatastoreAndCloudSql().withTaskQueue().build(); - - @RegisterExtension public final InjectExtension inject = new InjectExtension(); - private final FakeClock clock = new FakeClock(DateTime.parse("2021-05-24T20:21:22Z")); - private final SendEmailService sendEmailService = mock(SendEmailService.class); - private CertificateChecker certificateChecker; - private SendExpiringCertificateNotificationEmailAction action; - private Registrar sampleRegistrar; - private Response response; - private static final String expirationWarningEmailBodyText = + private static final String EXPIRATION_WARNING_EMAIL_BODY_TEXT = " Dear %1$s,\n" + "\n" + " We would like to inform you that your %2$s SSL certificate will expire at\n" @@ -109,9 +98,22 @@ class SendExpiringCertificateNotificationEmailActionTest { + "\n" + " Regards,\n" + " Google Registry\n"; - private static final String expirationWarningEmailSubjectText = + + private static final String EXPIRATION_WARNING_EMAIL_SUBJECT_TEXT = "[Important] Expiring SSL certificate for Google " + "Registry EPP connection"; + @RegisterExtension + public final AppEngineExtension appEngine = + AppEngineExtension.builder().withDatastoreAndCloudSql().withTaskQueue().build(); + + @RegisterExtension public final InjectExtension inject = new InjectExtension(); + private final FakeClock clock = new FakeClock(DateTime.parse("2021-05-24T20:21:22Z")); + private final SendEmailService sendEmailService = mock(SendEmailService.class); + private CertificateChecker certificateChecker; + private SendExpiringCertificateNotificationEmailAction action; + private Registrar sampleRegistrar; + private Response response; + @BeforeEach void beforeEach() throws Exception { certificateChecker = @@ -125,8 +127,8 @@ class SendExpiringCertificateNotificationEmailActionTest { action = new SendExpiringCertificateNotificationEmailAction( - expirationWarningEmailBodyText, - expirationWarningEmailSubjectText, + EXPIRATION_WARNING_EMAIL_BODY_TEXT, + EXPIRATION_WARNING_EMAIL_SUBJECT_TEXT, new InternetAddress("test@example.com"), sendEmailService, certificateChecker,