zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-06-27 06:44:51 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix the TestServer filter support added in []

Browse source 
In the previous CL I added filter support for the test server, but
even though I could verify that filters were being run when debugging,
in practice the side effects of the filters (notably, ObjectifyFilter
clearing the session cache) were somehow not present in tests (and
therefore causing new as-yet unsubmitted tests that rely on proper
session caching to break).

Investigating further, the way TestServer works is that it creates
a wrapper Servlet for each route, and in that wrapper just pushes
a future onto a queue and waits on it. The actual target servlet
is run within the queue, not within the wrapper servlet's context.
I had added filters to the *wrapper* servlet, which meant that even
though they were invoked before adding the task to the queue, they
were not invoked in the process of actually running the task.

In this CL I pushed the filters into the task itself, just like the
target servlet.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=144123637
This commit is contained in:
cgoldfeder 2017-01-10 13:49:35 -08:00 • committed by Ben McIlwain
parent e981bad0b3
commit 0859cde790
2 changed files with 41 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

25
javatests/google/registry/server/TestServer.java
View file

@ -15,11 +15,12 @@
package google.registry.server;
import static com.google.common.base.Preconditions.checkArgument;
import static com.google.common.util.concurrent.Runnables.doNothing;
import static google.registry.util.NetworkUtils.getCanonicalHostName;
import com.google.common.base.Throwables;
import com.google.common.collect.ImmutableList;
import com.google.common.net.HostAndPort;
import com.google.common.util.concurrent.Callables;
import com.google.common.util.concurrent.SimpleTimeLimiter;
import java.net.MalformedURLException;
import java.net.URL;
@ -34,7 +35,6 @@ import javax.annotation.Nullable;
import javax.servlet.Filter;
import javax.servlet.http.HttpServlet;
import org.mortbay.jetty.Connector;
import org.mortbay.jetty.Handler;
import org.mortbay.jetty.Server;
import org.mortbay.jetty.bio.SocketConnector;
import org.mortbay.jetty.servlet.Context;
@ -85,8 +85,8 @@ public final class TestServer {
public TestServer(
HostAndPort address,
Map<String, Path> runfiles,
Iterable<Route> routes,
Iterable<Class<? extends Filter>> filters) {
ImmutableList<Route> routes,
ImmutableList<Class<? extends Filter>> filters) {
urlAddress = createUrlAddress(address);
server.addConnector(createConnector(address));
server.addHandler(createHandler(runfiles, routes, filters));
@ -120,7 +120,7 @@ public final class TestServer {
* main event loop, for post-request processing.
*/
public void ping() {
requestQueue.add(new FutureTask<>(Callables.<Void>returning(null)));
requestQueue.add(new FutureTask<Void>(doNothing(), null));
}
/** Stops the HTTP server. */
@ -151,8 +151,8 @@ public final class TestServer {
private Context createHandler(
Map<String, Path> runfiles,
Iterable<Route> routes,
Iterable<Class<? extends Filter>> filters) {
ImmutableList<Route> routes,
ImmutableList<Class<? extends Filter>> filters) {
Context context = new Context(server, CONTEXT_PATH, Context.SESSIONS);
context.addServlet(new ServletHolder(HealthzServlet.class), "/healthz");
for (Map.Entry<String, Path> runfile : runfiles.entrySet()) {
@ -161,10 +161,8 @@ public final class TestServer {
runfile.getKey());
}
for (Route route : routes) {
context.addServlet(new ServletHolder(wrapServlet(route.servletClass())), route.path());
}
for (Class<? extends Filter> filter : filters) {
context.addFilter(filter, "/*", Handler.REQUEST);
context.addServlet(
new ServletHolder(wrapServlet(route.servletClass(), filters)), route.path());
}
ServletHolder holder = new ServletHolder(DefaultServlet.class);
holder.setInitParameter("aliases", "1");
@ -172,8 +170,9 @@ public final class TestServer {
return context;
}
private HttpServlet wrapServlet(Class<? extends HttpServlet> servletClass) {
return new ServletWrapperDelegatorServlet(servletClass, requestQueue);
private HttpServlet wrapServlet(
Class<? extends HttpServlet> servletClass, ImmutableList<Class<? extends Filter>> filters) {
return new ServletWrapperDelegatorServlet(servletClass, filters, requestQueue);
}
private static Connector createConnector(HostAndPort address) {