zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-13 07:57:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

Remove as-of date from argument list for extra create flow logic

Browse source 
Lai points out that, for creation, the as-of date should always be equal to the creation time. And, in fact, there was a check to throw an exception if that is not the case. So it's more straightforward just to remove that argument entirely.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=138783711
This commit is contained in:
mountford 2016-11-10 11:27:50 -08:00 • committed by Ben McIlwain
parent 07a6e55f82
commit 0634e25822
3 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
java/google/registry/flows/domain/DomainCreateFlow.java
View file

@ -269,7 +269,7 @@ public class DomainCreateFlow implements TransactionalFlow {
.setContacts(command.getContacts())
.addGracePeriod(GracePeriod.forBillingEvent(GracePeriodStatus.ADD, createBillingEvent))
.build();
handleExtraFlowLogic(registry.getTldStr(), years, historyEntry, newDomain, now);
handleExtraFlowLogic(registry.getTldStr(), years, historyEntry, newDomain);
entitiesToSave.add(
newDomain,
ForeignKeyIndex.create(newDomain, newDomain.getDeletionTime()),
@ -396,7 +396,7 @@ public class DomainCreateFlow implements TransactionalFlow {
}
private void handleExtraFlowLogic(
String tld, int years, HistoryEntry historyEntry, DomainResource newDomain, DateTime now)
String tld, int years, HistoryEntry historyEntry, DomainResource newDomain)
throws EppException {
Optional<RegistryExtraFlowLogic> extraFlowLogic =
RegistryExtraFlowLogicProxy.newInstanceForTld(tld);
@ -404,7 +404,6 @@ public class DomainCreateFlow implements TransactionalFlow {
extraFlowLogic.get().performAdditionalDomainCreateLogic(
newDomain,
clientId,
now,
years,
eppInput,
historyEntry);