zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-22 18:55:58 +02:00
Code Issues Projects Releases Packages Wiki Activity

Add a converter for CurrencyUnits stored in the database (#334)

Browse source 
* Add a converter for CurrencyUnits stored in the database

This uses the well-known String representation for currency units. It also
provides a base class for other converters that will be persisting the
toString() representation.

* Add DB and formatting changes

* Add tests, make minor fixes
This commit is contained in:
Ben McIlwain 2019-10-31 15:26:40 -04:00 • committed by GitHub
parent d00ade8ae0
commit 03bbb2c057
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
16 changed files with 192 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

2
proxy/src/main/java/google/registry/proxy/metric/BaseMetrics.java
View file

@ -35,7 +35,7 @@ public abstract class BaseMetrics {
* nomulus -e production list_registrars -f clientCertificateHash | grep $HASH
* </pre>
*/
protected static final ImmutableSet<LabelDescriptor> LABELS =
protected static final ImmutableSet<LabelDescriptor> LABELS =
ImmutableSet.of(
LabelDescriptor.create("protocol", "Name of the protocol."),
LabelDescriptor.create(

9
proxy/src/test/java/google/registry/proxy/handler/FrontendMetricsHandlerTest.java
View file

@ -158,12 +158,9 @@ public class FrontendMetricsHandlerTest {
Duration latency2 = new Duration(requestTime2, responseTime2);
Duration latency3 = new Duration(requestTime3, responseTime3);
verify(metrics)
.responseSent(PROTOCOL_NAME, CLIENT_CERT_HASH, latency1);
verify(metrics)
.responseSent(PROTOCOL_NAME, CLIENT_CERT_HASH, latency2);
verify(metrics)
.responseSent(PROTOCOL_NAME, CLIENT_CERT_HASH, latency3);
verify(metrics).responseSent(PROTOCOL_NAME, CLIENT_CERT_HASH, latency1);
verify(metrics).responseSent(PROTOCOL_NAME, CLIENT_CERT_HASH, latency2);
verify(metrics).responseSent(PROTOCOL_NAME, CLIENT_CERT_HASH, latency3);
verifyNoMoreInteractions(metrics);
}
}