zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-06-27 14:54:51 +02:00
Code Issues Projects Releases Packages Wiki Activity

Do not explicitly depend on latest GKE version

Browse source 
When versions are explicitly set to the latest available version, Annealing almost always fails to apply the patch due to yet-unknown reasons. The rationale for setting the versions explicitly was to ensure that the clusters are always updated in time. But it seems like it is not worth the trouble.

Without the explicit latest versions, the master should still be automatic upgrade (may not be immediate after version availability):

https://cloud.google.com/kubernetes-engine/versioning-and-upgrades#automatic_master_upgrades

We also set "Auto Upgrade" on the nodes, which should upgrades the nodes to master versions (may not be immediate after master version upgrade).

So it seems without these lines, we can still expect the gke versions of the cluster to upgrade (eventually).

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=206408347
This commit is contained in:
jianglai 2018-07-27 19:54:08 -07:00
parent be189354da
commit 030e2f4dd3
1 changed files with 0 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
java/google/registry/proxy/terraform/modules/gke/cluster.tf
View file

@ -2,15 +2,9 @@ locals {
proxy_cluster_zone = "${lookup(var.proxy_cluster_zones, var.proxy_cluster_region)}"
}
data "google_container_engine_versions" "gke_version" {
zone = "${local.proxy_cluster_zone}"
}
resource "google_container_cluster" "proxy_cluster" {
name = "proxy-cluster-${var.proxy_cluster_region}"
zone = "${local.proxy_cluster_zone}"
node_version = "${data.google_container_engine_versions.gke_version.latest_node_version}"
min_master_version = "${data.google_container_engine_versions.gke_version.latest_master_version}"
timeouts {
update = "30m"