zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-07-20 17:56:08 +02:00
Code Issues Projects Releases Packages Wiki Activity

Replace some unnecessary uses of "real" ofy() with Ofy.

Browse source 
Only Ofy itself and its two helpers (AugmentedSaver and
AugmentedDeleter) need to use the real ofy(). All other
callers should be using Ofy. Fixing this even though it
doesn't change anything because I found it baffling to
follow the code while trying to make a small change.

Update: added a presubmit to enforce this.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=154456603
This commit is contained in:
cgoldfeder 2017-04-27 12:40:36 -07:00 • committed by Ben McIlwain
parent 927eb43cbc
commit 0267214841
5 changed files with 25 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

18
java/google/registry/model/ofy/Ofy.java
View file

@ -107,6 +107,16 @@ public class Ofy {
return ofy().factory();
}
/**
* Returns keys read by Objectify during this transaction.
*
* <p>This won't include the keys of asynchronous save and delete operations that haven't been
* reaped.
*/
public ImmutableSet<Key<?>> getSessionKeys() {
return ((SessionKeyExposingObjectify) ofy()).getSessionKeys();
}
/** Clears the session cache. */
public void clearSessionCache() {
ofy().clear();
@ -120,9 +130,9 @@ public class Ofy {
checkState(inTransaction(), "Must be called in a transaction");
}
/**
/**
* Load from Datastore, bypassing memcache even when the results might be there.
*
*
* <p>In general, this is the correct method to use for loads. Loading from memcache can, in rare
* instances, produce a stale result (when a memcache write fails and the previous result is not
* cleared out) and so using memcache should be avoided unless the caller can tolerate staleness
@ -134,9 +144,9 @@ public class Ofy {
return ofy().cache(true).load();
}
/**
/**
* Load from Datastore, bypassing memcache even when the results might be there.
*
*
* <p>In general, prefer {@link #load} over this method. Loading from memcache can, in rare
* instances, produce a stale result (when a memcache write fails and the previous result is not
* cleared out) and so using memcache should be avoided unless the caller can tolerate staleness