From 021405eb17cccbab6cb5e43ec3fd447339fd9e7d Mon Sep 17 00:00:00 2001 From: cpovirk Date: Fri, 3 May 2019 15:15:13 -0700 Subject: [PATCH] Migrate Truth Subjects from no-arg check() to use description The overload that accepts a description generally produces better failure messages: - The first line of the message it produces is something like: "value of: myProto.getResponse()" (where "getResponse()" is taken from the provided description) - The last line of the message it produces is something like: "myProto was: response: query was throttled" (the full value of myProto) - And the existing text goes in between. Additional motivation: We are deleting the no-arg overload externally (and probably internally thereafter). Tested: TAP --sample ran all affected tests and none failed [] ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=246582329 --- javatests/google/registry/testing/LogsSubject.java | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/javatests/google/registry/testing/LogsSubject.java b/javatests/google/registry/testing/LogsSubject.java index 9794159a7..9ae5c2c76 100644 --- a/javatests/google/registry/testing/LogsSubject.java +++ b/javatests/google/registry/testing/LogsSubject.java @@ -61,16 +61,12 @@ public class LogsSubject extends Subject { } public void hasNoLogsAtLevel(Level level) { - check() - .withMessage("Logs at level %s", level) - .that(getMessagesAtLevel(level)) - .isEmpty(); + check("atLevel(%s)", level).that(getMessagesAtLevel(level)).isEmpty(); } public Which hasLogAtLevelWithMessage(Level level, String message) { List messagesAtLevel = getMessagesAtLevel(level); - check() - .withMessage("Logs at level %s", level) + check("atLevel(%s)", level) .that(messagesAtLevel) .comparingElementsUsing(CONTAINS_CORRESPONDENCE) .contains(message);