zydronium/getnamingo-registry
1
0
Fork 0
mirror of https://github.com/getnamingo/registry.git synced 2025-07-25 11:58:19 +02:00
Code Issues Projects Releases Packages Wiki Activity

Improved nameserver validation (WHOIS)

Browse source
This commit is contained in:
Pinga 2025-04-23 12:29:20 +03:00
parent 6f7f767547
commit db00aaffeb
3 changed files with 46 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

40
whois/port43/helpers.php
View file

@ -113,3 +113,43 @@ function updatePermittedIPs($pool, $permittedIPsTable) {
$permittedIPsTable->set($ip, ['addr' => $ip]);
}
}
function isValidHostname($hostname) {
$hostname = trim($hostname);
// Convert IDN (Unicode) to ASCII if necessary
if (mb_detect_encoding($hostname, 'ASCII', true) === false) {
$hostname = idn_to_ascii($hostname, IDNA_NONTRANSITIONAL_TO_ASCII, INTL_IDNA_VARIANT_UTS46);
if ($hostname === false) {
return false; // Invalid IDN conversion
}
}
// Ensure there is at least **one dot** (to prevent single-segment hostnames)
if (substr_count($hostname, '.') < 1) {
return false;
}
// Regular expression for validating a hostname
$pattern = '/^((xn--[a-zA-Z0-9-]{1,63}|[a-zA-Z0-9-]{1,63})\.)*([a-zA-Z0-9-]{1,63}|xn--[a-zA-Z0-9-]{2,63})$/';
// Ensure it matches the hostname pattern
if (!preg_match($pattern, $hostname)) {
return false;
}
// Ensure no label exceeds 63 characters
$labels = explode('.', $hostname);
foreach ($labels as $label) {
if (strlen($label) > 63) {
return false;
}
}
// Ensure full hostname is not longer than 255 characters
if (strlen($hostname) > 255) {
return false;
}
return true;
}

2
whois/port43/start_whois.php
View file

@ -658,7 +658,7 @@ $server->on('receive', function ($server, $fd, $reactorId, $data) use ($c, $pool
}
}
if (!preg_match('/^((xn--[a-zA-Z0-9-]{1,63}|[a-zA-Z0-9-]{1,63})\.){2,}(xn--[a-zA-Z0-9-]{2,63}|[a-zA-Z]{2,63})$/', $nameserver)) {
if (!isValidHostname($nameserver)) {
$server->send($fd, "Nameserver contains invalid characters or is not in the correct format.");
$server->close($fd);
}

2
whois/port43/whois_limited.php
View file

@ -296,7 +296,7 @@ $server->on('receive', function ($server, $fd, $reactorId, $data) use ($c, $pool
}
}
if (!preg_match('/^((xn--[a-zA-Z0-9-]{1,63}|[a-zA-Z0-9-]{1,63})\.){2,}(xn--[a-zA-Z0-9-]{2,63}|[a-zA-Z]{2,63})$/', $nameserver)) {
if (!isValidHostname($nameserver)) {
$server->send($fd, "Nameserver contains invalid characters or is not in the correct format.");
$server->close($fd);
}