From 0737704be08b47d4fb9be517b56b9c2608d96c91 Mon Sep 17 00:00:00 2001
From: Pinga <121483313+getpinga@users.noreply.github.com>
Date: Tue, 5 Nov 2024 10:02:26 +0200
Subject: [PATCH] Correctly capture and log output from OpenDNSSEC

---
 automation/write-zone.php | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/automation/write-zone.php b/automation/write-zone.php
index d1e961d..770872b 100644
--- a/automation/write-zone.php
+++ b/automation/write-zone.php
@@ -192,7 +192,10 @@ Coroutine::create(function () use ($pool, $log, $c) {
                 chown("{$basePath}/{$cleanedTld}.zone", 'opendnssec');
                 chgrp("{$basePath}/{$cleanedTld}.zone", 'opendnssec');
 
-                exec("ods-signer sign {$cleanedTld} 2>&1");
+                exec("ods-signer sign {$cleanedTld} 2>&1", $output, $return_var);
+                if ($return_var != 0) {
+                    $log->error("Failed to sign zone with OpenDNSSEC for {$cleanedTld}. Output: " . implode(" ", $output) . " Code: " . $return_var);
+                }
                 sleep(1);
                 copy("/var/lib/opendnssec/signed/{$cleanedTld}", "/var/lib/bind/{$cleanedTld}.zone.signed");