From 2c53515b6041e55c4bd4106320e4aa4ce13e9d38 Mon Sep 17 00:00:00 2001 From: Bryan Ashby Date: Wed, 31 Aug 2016 22:06:49 -0600 Subject: [PATCH] Better isGroupMember() impl. --- core/user.js | 22 +++++++--------------- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/core/user.js b/core/user.js index 7446c872..0288d8dd 100644 --- a/core/user.js +++ b/core/user.js @@ -60,28 +60,20 @@ function User() { groupNames = [ groupNames ]; } - // :TODO: _.some() - - var isMember = false; - - _.forEach(groupNames, groupName => { - if(-1 !== self.groups.indexOf(groupName)) { - isMember = true; - return false; // stop iteration - } - }); - + const isMember = groupNames.some(gn => (-1 !== self.groups.indexOf(gn))); return isMember; }; this.getLegacySecurityLevel = function() { if(self.isRoot() || self.isGroupMember('sysops')) { return 100; - } else if(self.isGroupMember('users')) { - return 30; - } else { - return 10; // :TODO: Is this what we want? } + + if(self.isGroupMember('users')) { + return 30; + } + + return 10; // :TODO: Is this what we want? }; }