zydronium/SMBLibrary
1
0
Fork 0
mirror of https://github.com/TalAloni/SMBLibrary.git synced 2025-07-12 20:38:09 +02:00
Code Issues Projects Releases Packages Wiki Activity

NBTConnectionReceiveBuffer: Dispose: Fix thread-safety issue

Browse source
This commit is contained in:
Tal Aloni 2024-02-05 21:26:56 +02:00
parent 39388660d3
commit f366c78fc9
1 changed files with 14 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

20
SMBLibrary/NetBios/NBTConnectionReceiveBuffer.cs
View file

@ -1,4 +1,4 @@
/* Copyright (C) 2014-2023 Tal Aloni <tal.aloni.il@gmail.com>. All rights reserved. /* Copyright (C) 2014-2024 Tal Aloni <tal.aloni.il@gmail.com>. All rights reserved.
* *
* You can redistribute this program and/or modify it under the terms of * You can redistribute this program and/or modify it under the terms of
* the GNU Lesser Public License as published by the Free Software Foundation, * the GNU Lesser Public License as published by the Free Software Foundation,
@ -15,6 +15,9 @@ namespace SMBLibrary.NetBios
{ {
public class NBTConnectionReceiveBuffer : IDisposable public class NBTConnectionReceiveBuffer : IDisposable
{ {
#if NETSTANDARD2_0
private object m_bufferSyncLock = new object();
#endif
private byte[] m_buffer; private byte[] m_buffer;
private int m_readOffset = 0; private int m_readOffset = 0;
private int m_bytesInBuffer = 0; private int m_bytesInBuffer = 0;
@ -127,13 +130,18 @@ namespace SMBLibrary.NetBios
public void Dispose() public void Dispose()
{ {
if (m_buffer != null)
{
#if NETSTANDARD2_0 #if NETSTANDARD2_0
ArrayPool<byte>.Shared.Return(m_buffer); lock (m_bufferSyncLock)
#endif {
m_buffer = null; if (m_buffer != null)
{
ArrayPool<byte>.Shared.Return(m_buffer);
m_buffer = null;
}
} }
#else
m_buffer = null;
#endif
} }
public byte[] Buffer public byte[] Buffer